Added Pointtype PointXYZLNormal to common #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschoeler
force-pushed
the
New_Point_Type
branch
from
d12d3aa
to
08a32ff
Compare
| x = y = z = 0.0f; | ||
| data[3] = 1.0f; | ||
| normal_x = normal_y = normal_z = data_n[3] = 0.0f; | ||
| label = 0; |
There was a problem hiding this comment.
Zero-initialize curvature as well?
There was a problem hiding this comment.
I don't know. I basically copied over the code from PointXYZINormal.
There was a problem hiding this comment.
Not sure why that point type misses curvature initialization, but I think it makes much sense to initialize.
There was a problem hiding this comment.
ok done. also changed the XYZINormal accordingly.
mschoeler
force-pushed
the
New_Point_Type
branch
from
08a32ff
to
78f4a6b
Compare
taketwo
added a commit
that referenced
this pull request
Oct 16, 2014
Added Pointtype PointXYZLNormal to common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the Pointtype PointXYZLNormal to common. It is needed for the pull request #895.