Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PCLVisualizer::addCube function. #846

Merged
merged 1 commit into from
Aug 15, 2014
Merged

Fix for PCLVisualizer::addCube function. #846

merged 1 commit into from
Aug 15, 2014

Conversation

nylocx
Copy link

@nylocx nylocx commented Aug 15, 2014

Using vtkLODActor instead of vtkActor to avoid crashes in updateShapePose function.

Using vtkLODActor instead of vtkActor to avoid crashes in updateShapePose function.
@taketwo
Copy link
Member

taketwo commented Aug 15, 2014

Is this change compatible with both vtk5 and vtk6?

@nylocx
Copy link
Author

nylocx commented Aug 15, 2014

I have not tested with vtk6 but as all other functions in the PCLVisualizer class use vtkLODActor as actors I guess it was just a typo that this function was using vtkActor. So I would say it's compatible.

@taketwo
Copy link
Member

taketwo commented Aug 15, 2014

Okay, thank you!

taketwo added a commit that referenced this pull request Aug 15, 2014
Fix for PCLVisualizer::addCube function.
@taketwo taketwo merged commit 40af521 into PointCloudLibrary:master Aug 15, 2014
@nylocx nylocx deleted the addCubeFix branch August 15, 2014 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants