Use common file for boost versions. #5960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvieth
reviewed
Feb 13, 2024
| @@ -93,13 +93,8 @@ macro(find_boost) | |||
| elseif(NOT BOOST_INCLUDEDIR) | |||
| set(BOOST_INCLUDEDIR "@Boost_INCLUDE_DIR@") | |||
| endif() | |||
|
|
|||
| set(Boost_ADDITIONAL_VERSIONS | |||
| "@Boost_MAJOR_VERSION@.@Boost_MINOR_VERSION@.@Boost_SUBMINOR_VERSION@" "@Boost_MAJOR_VERSION@.@Boost_MINOR_VERSION@" | |||
There was a problem hiding this comment.
What about this line? This would be lost. Maybe something like
set(Boost_ADDITIONAL_VERSIONS "@Boost_MAJOR_VERSION@.@Boost_MINOR_VERSION@.@Boost_SUBMINOR_VERSION@" "@Boost_MAJOR_VERSION@.@Boost_MINOR_VERSION@" ${Boost_ADDITIONAL_VERSIONS})There was a problem hiding this comment.
But the Boost_MAJOR_VERSION etc. refers to the boost that PCL was build with - so that should already be in that original list?
but maybe it should just be that one that stays or is the intention that you fx. build PCL with boost 1.75.0 and then use another boost version in the downstream project? Wouldn't make that much sense?
There was a problem hiding this comment.
This logic was added in #1630 . If I understand correctly, it exists so that CMake prefers the Boost version that PCL was built with.
There was a problem hiding this comment.
Yeah, I guess we can keep it that way.
mvieth
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2559