Add omp and inline executor support for functor filter #4371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This project was a part of GSoC 2020 under the mentorship of @kunaltyagi & @SergioRAgostinho
Update Filter & FilterIndices with a CRTP based design in order to allow executor overloads. Virtual functions cannot be templated so executors cannot work with it.
OpenMP executor enables parallelization. For most functors limit max number of threads to 8 since performance gains are minimal after that.
shrijitsingh99
requested review from
kunaltyagi and
SergioRAgostinho
and removed request for
kunaltyagi
|
To be merged post #4370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenMP executor offers a good boost due to parallelization up to 8 threads. After that the gains are marginal.
Benchmarks to come in a later PR.