Replace '.points[' with just '[' #4219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioRAgostinho
approved these changes
Jun 29, 2020
Comment on lines
+117
to
+119
| cloud_out[i].x = static_cast<float>(p[0]); | ||
| cloud_out[i].y = static_cast<float>(p[1]); | ||
| cloud_out[i].z = static_cast<float>(p[2]); |
Comment on lines
+18
to
+20
| cloud[i].x = 1024 * rand () / (RAND_MAX + 1.0f); | ||
| cloud[i].y = 1024 * rand () / (RAND_MAX + 1.0f); | ||
| cloud[i].z = 1024 * rand () / (RAND_MAX + 1.0f); |
| } | ||
|
|
||
| pcl::io::savePCDFileASCII ("test_pcd.pcd", cloud); | ||
| std::cerr << "Saved " << cloud.points.size () << " data points to test_pcd.pcd." << std::endl; | ||
|
|
||
| for (std::size_t i = 0; i < cloud.points.size (); ++i) | ||
| std::cerr << " " << cloud.points[i].x << " " << cloud.points[i].y << " " << cloud.points[i].z << std::endl; | ||
| std::cerr << " " << cloud[i].x << " " << cloud[i].y << " " << cloud[i].z << std::endl; | ||
|
|
||
| return (0); | ||
| } |
There was a problem hiding this comment.
No. clang-format remember
| @@ -102,7 +102,7 @@ main (int, char** argv) | |||
| std::cout<<" with size "<<rift_output.points.size()<<std::endl; | |||
|
|
|||
| // Display and retrieve the rift descriptor vector for the first point | |||
| pcl::Histogram<32> first_descriptor = rift_output.points[0]; | |||
| pcl::Histogram<32> first_descriptor = rift_output[0]; | |||
There was a problem hiding this comment.
no need to create a copy.
SergioRAgostinho
added
needs: author reply
|
I'd recommend a separate PR for these 4 points. |
SergioRAgostinho
removed
the
needs: author reply
kunaltyagi
added a commit
to kunaltyagi/pcl
that referenced
this pull request
Jul 3, 2020
kunaltyagi
added a commit
to kunaltyagi/pcl
that referenced
this pull request
Jul 3, 2020
kunaltyagi
added a commit
to kunaltyagi/pcl
that referenced
this pull request
Jul 3, 2020
SergioRAgostinho
added a commit
that referenced
this pull request
Jul 3, 2020
Adding changes requested in #4219
koide3
pushed a commit
to koide3/pcl
that referenced
this pull request
Jul 6, 2020
* Reuse code, add exception in cuda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.