[common] Add always-unsigned index type uindex_t dependent on index_t
#4205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaltyagi
reviewed
Jun 18, 2020
kunaltyagi
added
changelog: new feature
kunaltyagi
changed the title
uindex_t dependent on index_t
kunaltyagi
approved these changes
Jun 19, 2020
kunaltyagi
added
needs: code review
SergioRAgostinho
approved these changes
Jun 19, 2020
| * Unsigned index that mirrors the type of the index_t | ||
| */ | ||
| using uindex_t = detail::int_type_t<detail::index_type_size, false>; | ||
| static_assert(!std::is_signed<uindex_t>::value, "`uindex_t` must be unsigned"); |
There was a problem hiding this comment.
I'm not sure if this check should be here but it's minor. I think I would have placed it somewhere in the unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.