Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Fix name warnings for PCAP, libusb and Ensenso. #4182

Merged
merged 1 commit into from
Jun 14, 2020
Merged

[CMake] Fix name warnings for PCAP, libusb and Ensenso. #4182

merged 1 commit into from
Jun 14, 2020

Conversation

larshg
Copy link
Contributor

@larshg larshg commented Jun 13, 2020

No description provided.

kunaltyagi
kunaltyagi approved these changes Jun 13, 2020
View reviewed changes
Copy link
Member

@kunaltyagi kunaltyagi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New names match filenames. Second pair of eyes would be nice 😄

And a classification for changelog (fix/enhancement for removing the warnings in CMake)

@kunaltyagi kunaltyagi added module: cmake needs: code review Specify why not closed/merged yet labels Jun 13, 2020
@larshg
Copy link
Contributor Author

larshg commented Jun 13, 2020

More important, the name used in find_package for the libraries:

pcl/CMakeLists.txt

Line 308 in 0dfb3fc

find_package(libusb-1.0)

pcl/CMakeLists.txt

Line 317 in 0dfb3fc

PCL_ADD_GRABBER_DEPENDENCY("Ensenso" "IDS-Imaging Ensenso camera support")

pcl/CMakeLists.txt

Line 450 in 0dfb3fc

find_package(Pcap)

@SergioRAgostinho SergioRAgostinho added changelog: fix Meta-information for changelog generation and removed needs: code review Specify why not closed/merged yet labels Jun 14, 2020
@SergioRAgostinho SergioRAgostinho merged commit 2e77ade into PointCloudLibrary:master Jun 14, 2020
@larshg larshg deleted the FixCmakeWarningsSimple branch June 14, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunaltyagi kunaltyagi kunaltyagi approved these changes

Assignees
No one assigned
Labels
changelog: fix Meta-information for changelog generation module: cmake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larshg @kunaltyagi @SergioRAgostinho