Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMake] Add option to choose
pcl::index_t
while compiling #4166[CMake] Add option to choose
pcl::index_t
while compiling #4166Changes from 13 commits
3b11a2a
b78a2ad
2810fda
60cc20f
c8efa4d
08e6a73
0a9670a
3922340
9000c58
f10d8c2
1910570
6861e24
3ec2691
79e7e2b
7257576
dd9a404
7912d9f
9059add
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
PCL_INDEX_SIZE_TEMP
might be better instead of${PCL_INDEX_SIZE}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like I can't follow both of these suggestions together. If I undefine
PCL_INDEX_SIZE_TEMP
, then at compile timePCL_INDEX_SIZE
cannot be set to it, because it is no longer available.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yeah. Can we just remove the temporary variable in that case? It's sole use seems to be comparison with 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unresolving the conversation, because
PCL_INDEX_SIZE_TEMP
still needs to be removed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I thought by remove @kunaltyagi meant I should undef
PCL_INDEX_SIZE_TEMP
, not get rid of it altogether.Is this what you had in mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I interpreted, because there's no need to actually define anything.