Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualizer] Fix crashes and exceptions in updatePointCloud() #4017

Merged
merged 2 commits into from
May 8, 2020

Conversation

larshg
Copy link
Contributor

@larshg larshg commented May 2, 2020

Setting the Cells count more explicitly seems to do the trick.

vertices->SetCells (nr_points, cells);

Failed to correctly identify that we changed its array/count. Maybe, one should look into this another day,

Closes #3452

@kunaltyagi
Copy link
Member

Perhaps merge the test with the code. And if it fixes the test, looks like you get 1 week worth of beer (or the drink of your choice)

@kunaltyagi kunaltyagi added changelog: fix Meta-information for changelog generation module: visualization needs: testing Specify why not closed/merged yet labels May 2, 2020
@larshg
Copy link
Contributor Author

larshg commented May 2, 2020

I just added them in seperate PRs. so we can see it actually fail now, before the fix gets merged.

@kunaltyagi
Copy link
Member

Please keep in mind that merging a failing test into master makes little sense.

If the CI fails there, that'd confirm that the test is correct. After that, please consider moving those tests here and we'll merge once the CI turns green.

@kunaltyagi kunaltyagi added this to the pcl-1.11.0 milestone May 3, 2020
@kunaltyagi kunaltyagi added needs: more work Specify why not closed/merged yet and removed needs: testing Specify why not closed/merged yet labels May 4, 2020
Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's also close #4016 in favor of another issue/PR to track the issue of the tests not being compiled/run?

@kunaltyagi kunaltyagi added needs: code review Specify why not closed/merged yet and removed needs: more work Specify why not closed/merged yet labels May 6, 2020
@kunaltyagi kunaltyagi added needs: testing Specify why not closed/merged yet and removed needs: code review Specify why not closed/merged yet labels May 6, 2020
@kunaltyagi
Copy link
Member

CI is green.

@larshg Please squash to have only 2 commits (test + mitigation). Ping someone after that so we can merge it.

@kunaltyagi kunaltyagi added needs: author reply Specify why not closed/merged yet and removed needs: testing Specify why not closed/merged yet labels May 6, 2020
@kunaltyagi kunaltyagi removed the needs: author reply Specify why not closed/merged yet label May 8, 2020
@kunaltyagi
Copy link
Member

Merging because no content changed, and CI was green before

@kunaltyagi kunaltyagi merged commit ff2c07c into PointCloudLibrary:master May 8, 2020
@larshg larshg deleted the FixUpdatePointCloud branch May 8, 2020 15:21
@taketwo taketwo changed the title [Visualizer] Fixes #4001 and #3452. [Visualizer] Fix crashes and exceptions in updatePointCloud() May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Meta-information for changelog generation module: visualization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when calling updatePointCloud
3 participants