Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PointCloud to conform to requirements of ReversibleContainer #3980

Merged
merged 3 commits into from
May 21, 2020
Merged

Update PointCloud to conform to requirements of ReversibleContainer #3980

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6853dd9
Update iterator to conform to requirements of ReversibleContainer
shrijitsingh99 Apr 26, 2020
507b806
Fix const overloading return type mismatch
shrijitsingh99 Apr 26, 2020
3a9d436
Trigger CI
shrijitsingh99 May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions common/include/pcl/point_cloud.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,10 +439,20 @@ namespace pcl
// iterators
using iterator = typename VectorType::iterator;
using const_iterator = typename VectorType::const_iterator;
inline iterator begin () { return (points.begin ()); }
inline iterator end () { return (points.end ()); }
inline const_iterator begin () const { return (points.begin ()); }
inline const_iterator end () const { return (points.end ()); }
using reverse_iterator = typename VectorType::reverse_iterator;
using const_reverse_iterator = typename VectorType::const_reverse_iterator;
inline iterator begin () noexcept { return (points.begin ()); }
inline iterator end () noexcept { return (points.end ()); }
inline const_iterator begin () const noexcept { return (points.begin ()); }
inline const_iterator end () const noexcept { return (points.end ()); }
inline const_iterator cbegin () const noexcept { return (points.cbegin ()); }
inline const_iterator cend () const noexcept { return (points.cend ()); }
inline reverse_iterator rbegin () noexcept { return (points.rbegin ()); }
inline reverse_iterator rend () noexcept { return (points.rend ()); }
inline const_reverse_iterator rbegin () const noexcept { return (points.rbegin ()); }
inline const_reverse_iterator rend () const noexcept { return (points.rend ()); }
inline const_reverse_iterator crbegin () const noexcept { return (points.crbegin ()); }
inline const_reverse_iterator crend () const noexcept { return (points.crend ()); }

//capacity
inline std::size_t size () const { return (points.size ()); }
Expand Down