Fix excessive warnings reported by MSVC #3964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaltyagi
added
needs: code review
|
Is it not better to actually, pass to MSVC an explicit global option to ignore unknown pragmas. This is something we definitely want to have enabled globally. Edit: According to this |
|
No idea on the correct approach since I'm just applying a "patch" to a temporary fix. We haven't needed this warning before and it'll be removed in 1.12 so modifying behavior of all downwind users temporarily doesn't make much sense. |
SergioRAgostinho
approved these changes
Apr 23, 2020
SergioRAgostinho
removed
the
needs: code review
taketwo
changed the title
truhoang
pushed a commit
to truhoang/pcl
that referenced
this pull request
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small PR to workaround MSVC's non-standard behavior.
MSVC doesn't ignore unknown pragma. So this PR disables that particular warning for one particular occurrence of the unknown pragma.