Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common] Refactor PCL_DEPRECATED macro #3945

Merged
merged 2 commits into from
Apr 23, 2020
Merged

[common] Refactor PCL_DEPRECATED macro #3945

merged 2 commits into from
Apr 23, 2020

Conversation

kunaltyagi
Copy link
Member

@kunaltyagi kunaltyagi commented Apr 18, 2020 •
edited by taketwo
Loading

Refactored for

New error stack shows only PCL_DEPRECATED and PCL_DEPRECATED_IMPL, with the relevant lines being quite understandable.

@kunaltyagi kunaltyagi added changelog: enhancement Meta-information for changelog generation needs: code review Specify why not closed/merged yet module: common labels Apr 18, 2020
@kunaltyagi kunaltyagi self-assigned this Apr 18, 2020
@kunaltyagi kunaltyagi mentioned this pull request Apr 18, 2020
Merged
@diivm diivm mentioned this pull request Apr 18, 2020
Merged
@kunaltyagi kunaltyagi requested a review from taketwo April 20, 2020 04:50
@kunaltyagi kunaltyagi added needs: feedback Specify why not closed/merged yet and removed needs: code review Specify why not closed/merged yet labels Apr 21, 2020
@kunaltyagi kunaltyagi added needs: code review Specify why not closed/merged yet and removed needs: feedback Specify why not closed/merged yet labels Apr 21, 2020
taketwo
taketwo reviewed Apr 22, 2020
View reviewed changes
Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable!

common/include/pcl/pcl_macros.h Outdated Show resolved Hide resolved
@kunaltyagi @taketwo
Oops. Left one out
c99397e 
Co-Authored-By: Sergey Alexandrov <alexandrov88@gmail.com>
@kunaltyagi
Copy link
Member Author

Note: remove pr_merge from #3931 post merge

@SergioRAgostinho SergioRAgostinho merged commit cb570cc into PointCloudLibrary:master Apr 23, 2020
@taketwo taketwo changed the title [common] Refactoring PCL_DEPRECATED macro [common] Refactor PCL_DEPRECATED macro May 10, 2020
truhoang pushed a commit to truhoang/pcl that referenced this pull request Jun 30, 2020
@kunaltyagi @taketwo @truhoang
[common] Refactoring PCL_DEPRECATED macro (PointCloudLibrary#3945)
d8f86ab 
Co-Authored-By: Sergey Alexandrov <alexandrov88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

@taketwo taketwo taketwo approved these changes

Assignees

@kunaltyagi kunaltyagi

Labels
changelog: enhancement Meta-information for changelog generation module: common needs: code review Specify why not closed/merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kunaltyagi @taketwo @SergioRAgostinho