[sample_consensus] Use better types for indices: int -> index_t, std::vector<int> ->Indices

[mvieth]

Sorry for the big commit, I didn't see a way to divide that logically.

[kunaltyagi]

LGTM. Maybe a followup PR for std::size_t to index_t where feasible.

[mvieth]

I think std::size_t is used nowhere as a type for indices in sample consensus, is it?

[kunaltyagi]

is it?

I don't know, sorry. Just something that popped in my mind. I'll have better access to PCL code in sometime when I'll be able to grok and tell you but you might be able to do that by the time I provide a yay/nay.

[taketwo]

@kunaltyagi Sorry I'm gonna bug you with some changelog-related sidenotes again 😬 Why do you add [module] prefix to the title? We already have a label for that!

[kunaltyagi]

Why do you add [module] prefix to the title?

• [XYZ] is shorter and less ambiguous than alternatives like in XYZ or in module XYZ
• more readable while reviewing PR/looking at the notification

I don't add it for the changelog...

[taketwo]

OK, I see the point. Still, as it stands, the line in changelog will have module prefix twice (once from the PR title, and once generated from labels). I see two options: a) we modify changelog generation script to strip module prefixes from titles; b) we modify title after a PR is merged and is dormant (not generating new notifications in your inbox). I guess the former is better.

I don't add it for the changelog...

Didn't get what you mean with this.

[kunaltyagi]

Didn't get what you mean with this.

I add the [module] for the notifications (same as issues). Didn't think of the changelog format.

Stripping the first [] sounds more doable to me than using a bot to do it after a PR is merged.

[taketwo]

Stripping the first [] sounds more doable to me than using a bot to do it after a PR is merged.

Oh, I did not think about a bot, rather manual title change. But yeah, let's auto-strip on changelog generation. I will add this to my todo.