Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a memory leak in OctreeBase::operator= #3787

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Fix a memory leak in OctreeBase::operator= #3787

merged 2 commits into from
Mar 24, 2020

Conversation

kunaltyagi
Copy link
Member

@kunaltyagi kunaltyagi commented Mar 24, 2020 •
edited
Loading

Reported by: @maciejmatuszak

A better approach would be unique_ptr but grepping for root_node_ shows that it'd not be a simple task

@kunaltyagi kunaltyagi added needs: code review Specify why not closed/merged yet module: octree changelog: fix Meta-information for changelog generation labels Mar 24, 2020
@taketwo taketwo changed the title Quick-Fix for a leak in octree_base Fix a memory leak in OctreeBase Mar 24, 2020
@taketwo taketwo changed the title Fix a memory leak in OctreeBase Fix a memory leak in OctreeBase::operator= Mar 24, 2020
@taketwo taketwo removed the needs: code review Specify why not closed/merged yet label Mar 24, 2020
@taketwo taketwo merged commit 920a346 into PointCloudLibrary:master Mar 24, 2020
@kunaltyagi kunaltyagi deleted the octree-leak branch March 24, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho left review comments

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
changelog: fix Meta-information for changelog generation module: octree
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kunaltyagi @taketwo @SergioRAgostinho