Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default initialization of grid resolution in MarchingCubes #3718

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Add default initialization of grid resolution in MarchingCubes #3718

merged 1 commit into from
Mar 12, 2020

Conversation

diivm
Copy link
Contributor

@diivm diivm commented Mar 5, 2020

Fixes #3717

@kunaltyagi kunaltyagi added changelog: fix Meta-information for changelog generation module: surface needs: author reply Specify why not closed/merged yet labels Mar 5, 2020
@taketwo taketwo added needs: more work Specify why not closed/merged yet and removed needs: author reply Specify why not closed/merged yet labels Mar 6, 2020
@diivm
Add default initializer
aa50653 
add default initialization for grid resolutions
@diivm diivm changed the title Add initialisation to default constructor Add default initializer Mar 6, 2020
@diivm diivm requested review from kunaltyagi and taketwo March 6, 2020 16:51
kunaltyagi
kunaltyagi reviewed Mar 7, 2020
View reviewed changes
Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 32 a good default? If so, LGTM

@SergioRAgostinho
Copy link
Member

From quickly skimming the code with will generate a 32x32x32 voxel grid. It's not super resolution but the user will be able to see something.

@SergioRAgostinho SergioRAgostinho added needs: pr merge Specify why not closed/merged yet and removed needs: more work Specify why not closed/merged yet labels Mar 7, 2020
@kunaltyagi kunaltyagi changed the title Add default initializer [surface] Add default initializer to Marching Cubes Mar 12, 2020
@kunaltyagi kunaltyagi merged commit ebdccef into PointCloudLibrary:master Mar 12, 2020
@kunaltyagi kunaltyagi removed the needs: pr merge Specify why not closed/merged yet label Mar 15, 2020
@taketwo taketwo changed the title [surface] Add default initializer to Marching Cubes Add default initialization of grid resolution in MarchingCubes Mar 18, 2020
@diivm diivm deleted the fix-add_initialization branch April 1, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunaltyagi kunaltyagi kunaltyagi left review comments

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

@taketwo taketwo Awaiting requested review from taketwo

Assignees
No one assigned
Labels
changelog: fix Meta-information for changelog generation module: surface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MarchingCubes is not setting meaningful resolution in default ctor
4 participants
@diivm @SergioRAgostinho @taketwo @kunaltyagi