Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set is_dense based on actual cloud contents in removeNaNNormalsFromPointCloud() #3685

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Set is_dense based on actual cloud contents in removeNaNNormalsFromPointCloud() #3685

merged 1 commit into from
Feb 27, 2020

Conversation

shrijitsingh99
Copy link
Contributor

@shrijitsingh99 shrijitsingh99 commented Feb 27, 2020 •
edited
Loading

Resolved #2518

@shrijitsingh99 shrijitsingh99 changed the title Set is_dense parameter based on input cloud Set is_dense parameter based on input pointcloud Feb 27, 2020
SergioRAgostinho
SergioRAgostinho approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. To merge if CI runs green.

@SergioRAgostinho SergioRAgostinho merged commit e5b8fe5 into PointCloudLibrary:master Feb 27, 2020
@kunaltyagi kunaltyagi added the changelog: fix Meta-information for changelog generation label Feb 28, 2020
@shrijitsingh99 shrijitsingh99 deleted the nannormal-dense branch March 12, 2020 20:52
@taketwo taketwo changed the title Set is_dense parameter based on input pointcloud Properly set is_dense in removeNaNNormalsFromPointCloud() Mar 18, 2020
@taketwo taketwo changed the title Properly set is_dense in removeNaNNormalsFromPointCloud() Set is_dense based on actual cloud contents in removeNaNNormalsFromPointCloud() Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
changelog: fix Meta-information for changelog generation module: filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

non-dense point cloud becomes dense after pcl::removeNaNNormalsFromPointCloud
4 participants
@shrijitsingh99 @taketwo @SergioRAgostinho @kunaltyagi