-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade RSSDK2 warning message to status #3683
Downgrade RSSDK2 warning message to status #3683
Conversation
The linked issue contains CMake log such as:
It'd be better if the RSSDK2 log were similar to RSSDK. |
Preferably yes, but I also recon that in RSSDK we search for the files and directories ourselves, while in RSSDK2 we're using and looking for their config file (correct me if I'm wrong). Either it finds everything or it doesn't. So it might not be worth to aim for this level of uniformed report because the find mechanisms are not exactly the same. |
But the messaging mechanism is written by us. Just the |
Let me clarify then. Having this is ok
But I wouldn't care about having this
|
As I understood, I updated the status message to be in line with other CMake logs I didn't use "find_package_handle_standard_args(RSSDK2 DEFAULT_MSG RSSDK2_LIBRARIES RSSDK2_INCLUDE_DIRS)", since as already mentioned it would be redundant to display what's missing in this case. |
* Downgrade package not found warning to status * Update status message
Resolves #3490
I just suppressed the warning and display a message for now.
Anything else expected or any changes required?