Close the correct file in pcl::io::savePLYFileBinary
#3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaltyagi
approved these changes
Jan 25, 2020
|
Thanks! We'll merge it soon 🚀 |
|
Thank you all for the great software. |
taketwo
changed the title
pcl::io::savePLYFileBinary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3599
I kept the call to
closedespite it being redundant (thefstreamdestructor does this anaway) for the sake of consistency with other functions. AFAIK the only use case for manually closingfstreamobjects before going out of scope is to check the good flag which is not being done inpcl::io::savePLYFileBinary