Replace raw arrays with std::vectors in RangeImageBorderExtractor
#3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taketwo
reviewed
Jan 9, 2020
kunaltyagi
force-pushed
the
internals_upgrade
branch
from
04e61b3
to
c9609cc
Compare
|
OK, thanks for the discussion. Please replace the other arrays and we can merge this. |
|
PTAL. (I know you're busy with 1.10, just pinging) |
taketwo
changed the title
std::vectors in RangeImageBorderExtractor
taketwo
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shift from
newanddeleteto vectors.The implementation is complete. But is this the correct direction?