Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uint64_type by std::uint64_t #3435

Merged

Conversation

SunBlack
Copy link
Contributor

Removed additionally checks for size of uint64_type, as result will be always true, as this type is defined as:

unsigned integer type with width of exactly 8, 16, 32 and 64 bits respectively
(provided only if the implementation directly supports the type)

This fixes current compile issues due to bad PR with sed s/uint64_t/std::uint64_t for uint64_type before.

namespace pcl
{
namespace device
{
using std::uint64_type = unsigned long long;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PointCloudLibrary/maintainers allow API breakage here since this is an unstable module?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe deprecate it, and not use it. Like with pcl::int_t types

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of file is internal.h - this doesn't sound as it is intended to be used outside.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe deprecate it, and not use it. Like with pcl::int_t types

It is relevant to mention, that I have not been able to compile PCLs CUDA code with C++14 flags. So the usual deprecated attribute might be off-limits and we got rid of our custom deprecation pragmas.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a line in CHANGELOG (and/or RELEASE_NOTES) should be sufficient since this is an internal API and that is allowed to change without warnings.

@SergioRAgostinho SergioRAgostinho added the changelog: API break Meta-information for changelog generation label Oct 23, 2019
@SergioRAgostinho SergioRAgostinho merged commit f5997d3 into PointCloudLibrary:master Oct 23, 2019
@SunBlack SunBlack deleted the replace_uint64_type branch October 23, 2019 09:05
@taketwo taketwo changed the title [gpu] Replace uint64_type by std::uint64_t Replace uint64_type by std::uint64_t Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: API break Meta-information for changelog generation module: gpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants