Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect switch fallthrough in convolution operator #3429

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Fix incorrect switch fallthrough in convolution operator #3429

merged 1 commit into from
Oct 22, 2019

Conversation

SergioRAgostinho
Copy link
Member

Pulling this one out of #3427 since it is a bug.

@SergioRAgostinho SergioRAgostinho added this to the pcl-1.10.0 milestone Oct 21, 2019
@SergioRAgostinho SergioRAgostinho changed the title [filter] Fix incorrect switch fallthrough in convolution operator. Fix incorrect switch fallthrough in convolution operator. Oct 21, 2019
kunaltyagi
kunaltyagi approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@kunaltyagi kunaltyagi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking how it even worked then realized maybe people only used one (or less) switch

@SergioRAgostinho SergioRAgostinho merged commit a6e7188 into PointCloudLibrary:master Oct 22, 2019
@SergioRAgostinho SergioRAgostinho deleted the conv-fallthrough-bug branch October 22, 2019 06:42
@SergioRAgostinho SergioRAgostinho mentioned this pull request Oct 22, 2019
Closed
@kunaltyagi kunaltyagi mentioned this pull request Oct 22, 2019
Closed
22 tasks
@taketwo taketwo changed the title Fix incorrect switch fallthrough in convolution operator. Fix incorrect switch fallthrough in convolution operator Jan 18, 2020
@kunaltyagi kunaltyagi mentioned this pull request Apr 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunaltyagi kunaltyagi kunaltyagi approved these changes

Assignees
No one assigned
Labels
module: filters
Projects
None yet
Milestone
pcl-1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioRAgostinho @kunaltyagi