Use generic detection idiom in isFinite()
#3402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaltyagi
force-pushed
the
field_traits
branch
3 times, most recently
from
dfcb3c4
to
da6bbe9
Compare
taketwo
reviewed
Oct 9, 2019
|
Yeah, can't figure out the how to resolve the boost errors. They are too verbose 😅 |
kunaltyagi
force-pushed
the
field_traits
branch
from
1ceca19
to
ad1a116
Compare
taketwo
reviewed
Oct 13, 2019
|
I'll have a look at this later today 👍 |
SergioRAgostinho
approved these changes
Oct 14, 2019
taketwo
approved these changes
Oct 15, 2019
kunaltyagi
force-pushed
the
field_traits
branch
from
14111bf
to
1eae214
Compare
taketwo
changed the title
isFinite with more usage specificityisFinite with more usage specific…
taketwo
changed the title
isFinite with more usage specific…isFinite()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances PCL to have
isXYFinite,isXYZFinite,isNormalFiniteto handle specific cases in algorithm, not dependent on the actual type but still dependent on the contents.Adds concepts like classes for future modernization for SFINAE.
\fixes #2664 (the concerns raised in it)