Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pragma declaration for CI gcc, use "-Wdeprecated-declaratio… #3385

Merged
merged 1 commit into from
Sep 28, 2019
Merged

Fix pragma declaration for CI gcc, use "-Wdeprecated-declaratio… #3385

merged 1 commit into from
Sep 28, 2019

Conversation

kunaltyagi
Copy link
Member

CI doesn't like the wider warning flag (or it might be new)

@kunaltyagi kunaltyagi mentioned this pull request Sep 27, 2019
Closed
22 tasks
taketwo
taketwo approved these changes Sep 28, 2019
View reviewed changes
Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCC 7.4 did not like it either. I checked locally, -Wdeprecated-declarations works.

@taketwo taketwo changed the title Fix pragma declaration for CI gcc, use "-Wdeprecated-declarations" Fix pragma declaration for CI gcc, use "-Wdeprecated-declaratio… Sep 28, 2019
@taketwo taketwo merged commit 6541104 into PointCloudLibrary:master Sep 28, 2019
@kunaltyagi kunaltyagi deleted the deprecated_ignore_test branch September 29, 2019 00:58
@kunaltyagi kunaltyagi mentioned this pull request Apr 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
module: test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunaltyagi @taketwo