Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore deprecated use for testing surface::MovingLeastSquares #3378

Closed

Conversation

kunaltyagi
Copy link
Member

Also uses narrower deprecated-declaraion (doesn't cover "deprecated-copy")

@kunaltyagi kunaltyagi changed the title Ignore deprecated use for test in surface::MovingLeastSquares Ignore deprecated use for testing surface::MovingLeastSquares Sep 27, 2019
@kunaltyagi kunaltyagi mentioned this pull request Sep 27, 2019
22 tasks
@taketwo
Copy link
Member

taketwo commented Sep 27, 2019

Let's deal with this differently than with the concatenation function. The now-deprecated MovingLeastSquaresOMP does not have a slightly different functionality than MovingLeastSquares. Instead, it is an alias. Thus we should change this test to test OMP mode in the MovingLeastSquares class. I'll send a PR later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants