Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate getFieldIndex()/getFields() with first argument as cloud #3365

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Deprecate getFieldIndex()/getFields() with first argument as cloud #3365

merged 2 commits into from
Sep 26, 2019

Conversation

kunaltyagi
Copy link
Member

Pulled out the changes from #3354

@kunaltyagi @taketwo
Update with diff suggested by @taketwo
456d943 
Co-Authored-By: Sergey Alexandrov <alexandrov88@gmail.com>
@taketwo taketwo merged commit 9684d29 into PointCloudLibrary:master Sep 26, 2019
@taketwo taketwo added changelog: deprecation Meta-information for changelog generation module: common labels Sep 26, 2019
@kunaltyagi kunaltyagi deleted the deprecateFieldIndex branch September 26, 2019 12:58
@taketwo taketwo changed the title Deprecated getFieldIndex with first argument as cloud Deprecate getFieldIndex/getFields with first argument as cloud Sep 26, 2019
@taketwo
Copy link
Member

taketwo commented Sep 26, 2019

We forgot to replace calls to deprecated getFields(cloud, fields). I get looots of warnings.

@kunaltyagi
Copy link
Member Author

We should try to make -Werror a real possibility sometime in future. That'll get rid of forgetting to replace deprecated usage.

kunaltyagi added a commit to kunaltyagi/pcl that referenced this pull request Sep 26, 2019
@kunaltyagi
Removes deprecated usage of getFields(cloud, fields)
3ec8fc4 
Enhances PointCloudLibrary#3365
@kunaltyagi kunaltyagi mentioned this pull request Sep 26, 2019
Merged
@kunaltyagi
Copy link
Member Author

PTAL@#3374

@taketwo
Copy link
Member

taketwo commented Sep 26, 2019

We should try to make -Werror a real possibility sometime in future.

Absolutely!

kunaltyagi added a commit to kunaltyagi/pcl that referenced this pull request Sep 27, 2019
@kunaltyagi
Removes deprecated usage of getFields(cloud, fields)
9d13d25 
Enhances PointCloudLibrary#3365
@taketwo taketwo changed the title Deprecate getFieldIndex/getFields with first argument as cloud Deprecate getFieldIndex()/getFields() with first argument as cloud Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
changelog: deprecation Meta-information for changelog generation module: common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunaltyagi @taketwo