Prefer lambdas over binds #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioRAgostinho
force-pushed
the
bind-tools
branch
from
dfb50d9
to
12f70e8
Compare
SergioRAgostinho
added
needs: code review
taketwo
reviewed
Jun 23, 2019
tools/oni2pcd.cpp
Outdated
| @@ -83,7 +83,7 @@ main (int argc, char **argv) | |||
| } | |||
|
|
|||
| pcl::ONIGrabber* grabber = new pcl::ONIGrabber (argv[1], false, false); | |||
| std::function<void (const CloudConstPtr&) > f = boost::bind (&cloud_cb, _1); | |||
| std::function<void (const CloudConstPtr&) > f = [=] (const CloudConstPtr& cloud) { cloud_cb (cloud); }; | |||
There was a problem hiding this comment.
Don't need to capture here. But does not really matter :)
There was a problem hiding this comment.
Then I'll change it, don't merge yet. I wasn't sure the function could be trivially captured inside the closure.
taketwo
approved these changes
Jun 23, 2019
taketwo
reviewed
Jun 23, 2019
tools/davidsdk_viewer.cpp
Outdated
| @@ -93,8 +93,7 @@ main (int argc, | |||
| //davidsdk_ptr->setFileFormatToPLY(); | |||
| std::cout << "Using " << davidsdk_ptr->getFileFormat () << " file format" << std::endl; | |||
|
|
|||
| std::function<void | |||
| (const PointCloudXYZ::Ptr&)> f = boost::bind (&grabberCallback, _1); | |||
| std::function<void (const PointCloudXYZ::Ptr&)> f = [=] (const PointCloudXYZ::Ptr& cloud) { grabberCallback (cloud); }; | |||
There was a problem hiding this comment.
Also here and in ensenso_viewer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.