Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FLANN_STATIC macro #3157

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Remove FLANN_STATIC macro #3157

merged 1 commit into from
Jun 14, 2019

Conversation

UnaNancyOwen
Copy link
Member

@UnaNancyOwen UnaNancyOwen commented Jun 13, 2019 •
edited by taketwo
Loading

This pull request remove unnecessary macro (FLANN_STATIC).
It will fix an error C1083 that occurs when build user project with Visual C++.

As far as I can see, it's indeed unnecessary to pass FLANN_STATIC to any code that consumes FLANN. The only usage of this macro in the entire project is in a "cpp" file, so relevant only during compilation of FLANN itself.
Originally posted by @taketwo in #3147 (comment)

Closes #3147.

Remove FLANN_STATIC macro
96e799a 
Remove unnecessary macro (FLANN_STATIC).
@taketwo
Copy link
Member

taketwo commented Jun 13, 2019

We populate definitions from ${PC_FLANN_CFLAGS_OTHER} and it may contain something. (Although on Ubuntu it does not.)

@UnaNancyOwen
Copy link
Member Author

${PC_FLANN_CFLAGS_OTHER} is empty on Visual C++.

@taketwo taketwo merged commit fd72d2b into PointCloudLibrary:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
module: cmake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error C1083 about FLANN_STATIC on Visual C++
3 participants
@UnaNancyOwen @taketwo @SergioRAgostinho