Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused timer routines in "NCV.cu" #3135

Merged

Conversation

SunBlack
Copy link
Contributor

@SunBlack SunBlack commented Jun 7, 2019

Found this during #3134. Seems this is code that only compiles under Windows or with a GNUC compiler.

@SergioRAgostinho
Copy link
Member

What about this section?

//==============================================================================
//
// Timer
//
//==============================================================================
using NcvTimer = struct _NcvTimer *;
NCV_EXPORTS NcvTimer ncvStartTimer();
NCV_EXPORTS double ncvEndQueryTimerUs(NcvTimer t);
NCV_EXPORTS double ncvEndQueryTimerMs(NcvTimer t);

@taketwo
Copy link
Member

taketwo commented Jun 15, 2019

Yes, but these functions are not used anywhere and they are not API since this file is buried in src/ tree. So safe to remove.

@SergioRAgostinho
Copy link
Member

No question. I just want to add the section I highlighted to the list of removed things.

@SergioRAgostinho SergioRAgostinho merged commit 187c9a5 into PointCloudLibrary:master Jun 18, 2019
@SunBlack SunBlack deleted the remove_unused_routines branch June 18, 2019 08:13
@taketwo taketwo changed the title Remove unused timer routines in NCV.cu Remove unused timer routines in "NCV.cu" Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants