Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove magic numbers from organized_segmentation_demo app #3108

Merged
merged 9 commits into from
Jun 3, 2019
Merged

Remove magic numbers from organized_segmentation_demo app #3108

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bc996a7
change new to boost::make_shared
May 28, 2019
883d3fa
remove useless spaces
May 28, 2019
b40b42d
remove values set identically to default values
May 28, 2019
b799bf4
remove magic number
May 28, 2019
4616cb7
fix unsigned-signed comparison
May 28, 2019
51654c9
amend 4616cb7
May 28, 2019
192d442
revert bc996a7df45ebb6125bf6946b1d1a14a460e8831
May 28, 2019
31c8671
Revert "remove values set identically to default values"
Jun 3, 2019
d16c3f9
comment on values set identically to default values
Jun 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix unsigned-signed comparison
  • Loading branch information
Andrea Ponza committed May 28, 2019
commit 4616cb7570e6c3d624b9199315d7acb31950b053
2 changes: 1 addition & 1 deletion apps/src/organized_segmentation_demo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ OrganizedSegmentationDemo::cloud_cb (const CloudConstPtr& cloud)

for (const auto &euclidean_label_index : euclidean_label_indices)
{
if (euclidean_label_index.indices.size () > 1000)
if (euclidean_label_index.indices.size () > 1000u)
{
pcl::PointCloud<PointT> cluster;
pcl::copyPointCloud (*cloud, euclidean_label_index.indices,cluster);
Expand Down