Refactor AgastDetector7_12s_computeCornerScore #3092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
May 17, 2019 14:05
…gastDetector7_12s_is_a_corner in preparation for next commits
Before:
if (...)
return true;
else
return false;
Before:
if (cond1)
return (cond2)
else
return false;
Now:
return (cond1 && cond2)
Before:
if (cond1)
return (cond2)
else
return false;
Now:
return (cond1 && cond2)
Before:
if (cond1)
return (cond2)
else
return false;
Now:
return (cond1 && cond2)
Before:
if (cond1)
return (cond2)
else
return false;
Now:
return (cond1 && cond2)
Before:
if (cond1)
return true
else
return (cond2);
Now:
return ((cond1) || (cond2));
Before:
if (cond1)
if (cond2)
...
else
return false;
else
return false;
Now:
if ((cond1) && (cond2))
...
else
return false;
Before:
if (cond1)
return (cond2)
else
return (cond2 && cond3);
Now:
if (cond2)
return (cond1 || cond3)
else
return false;
Before:
if (cond)
return false;
else
...
Now:
if (!cond)
...
else
return false;
Before:
if (cond1)
if (cond2)
...
else
return false;
else
return false;
Now:
if ((cond1) && (cond2))
...
else
return false;
Before:
if (cond1)
if (cond2)
...
else
return false;
else
return false;
Now:
if ((cond1) && (cond2))
...
else
return false;
Before:
if (cond1)
return (cond2)
else
return (cond2 && cond3);
Now:
if (cond2)
return (cond1 || cond3)
else
return false;
Before:
if (cond1)
return (cond2)
else
return false;
Now:
return (cond1 && cond2)
Before:
if (cond1)
return (cond2)
else
return (cond2 && cond3);
Now:
if (cond2)
return (cond1 || cond3)
else
return false;
Before:
if (cond1)
if (cond2)
...
else
return false;
else
return false;
Now:
if ((cond1) && (cond2))
...
else
return false;
|
Don't forget to rebase this against the current master. We already pushed the fix that gets rid of these out of space errors in the Windows CI. |
|
? This PR is basing on latest commit in master. |
|
This pull request has been automatically marked as stale because it hasn't had Come back whenever you have time. We look forward to your contribution. |
|
As currently clang-format will be applied to whole source: Is it possible to merge this PR before? I don't believe I can rebase this as it touches to many lines :/ |
|
It'll take some time until we reach the |
taketwo
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had yesterday again a day full of updating dependencies, so I had again time to be a masochist ;). As last time I used this code to verify I didn't changed behavior.
Most changes are done with help of regular expressions. I'm happy that this exists.
Just in case you want to have fun: My favorite regexe to search for specific code snippets