Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newer Boost versions to Boost_ADDITIONAL_VERSIONS #3003

Conversation

SunBlack
Copy link
Contributor

No description provided.

@UnaNancyOwen
Copy link
Member

(This is a small thing,) It seems to be lined-up 5 versions on 1 line in basically.
Please move "1.70.0", "1.70" to new line.

"1.70.0" "1.70"
"1.69.0" "1.69" "1.68.0" "1.68" "1.67.0" "1.67" "1.66.0" "1.66" "1.65.1" "1.65.0" "1.65"

@SunBlack
Copy link
Contributor Author

SunBlack commented Apr 18, 2019

(This is a small thing,) It seems to be lined-up 5 versions on 1 line in basically.

I expected this comment 😆 But it is a bit strange to have a nearly empty line at beginning and not at last. Maybe we should change order of versions, or does this have any side effect?

With reordering:

set(Boost_ADDITIONAL_VERSIONS
  "1.55" "1.55.0" "1.56" "1.56.0" "1.57" "1.57.0" "1.58" "1.58.0" "1.59" "1.59.0"
  "1.60" "1.60.0" "1.61" "1.61.0" "1.62" "1.62.0" "1.63" "1.63.0" "1.63" "1.63.1"
  "1.64" "1.64.0" "1.65" "1.65.0" "1.65.1" "1.66" "1.66.0" "1.67" "1.67.0" "1.68" "1.68.1"
  "1.69" "1.69.0" "1.70" "1.70.0" )

Btw: If I move "1.70.0" "1.70" to a separate line, next line has still 6 entries, because of "1.65.1".

@UnaNancyOwen
Copy link
Member

UnaNancyOwen commented Apr 18, 2019

Maybe we should change order of versions, or does this have any side effect?

(This is my unfounded conjecture.) Maybe, I think that affects which version of Boost to find in case of installed multiple versions in system. Probably, It will return the first found version. Therefore, The order should be in descending order.
What do you think?

Btw: If I move "1.70.0" "1.70" to a separate line, next line has still 6 entries, because of "1.65.1".

I think that is an exception. :)

It is a very small problem whether add new line than change order.
It will not affect the operation. Which do you like new line or one line?

PCLConfig.cmake.in Outdated Show resolved Hide resolved
@SunBlack SunBlack force-pushed the update_Boost_ADDITIONAL_VERSIONS branch from 64ea19d to 883a78a Compare April 18, 2019 20:42
@UnaNancyOwen UnaNancyOwen merged commit e96dff8 into PointCloudLibrary:master Apr 19, 2019
@UnaNancyOwen
Copy link
Member

Thanks! 👍

@SunBlack SunBlack deleted the update_Boost_ADDITIONAL_VERSIONS branch April 19, 2019 08:42
@taketwo taketwo changed the title Add newer Boost versions to Boost_ADDITIONAL_VERSIONS Add newer Boost versions to Boost_ADDITIONAL_VERSIONS Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants