Prevent adding /MP
flag for MSVC in case any other language than C/CXX will be used (e.g. CUDA)
#2862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project we had currently sometimes issues with equivalent CMake code for the flag
/MP
. Reasonadd_compile_options("/MP")
will add/MP
flag to all compilers - even CUDA. Currently this isn't an issue in PCL, because PCL is using CUDA viafind_package(CUDA)
and not via modern variant (project(pcl CXX CUDA)
), see here.So currently we have 3 options:
CMAKE_CXX_FLAGS
) and add a comment how it looks like if minimum required CMake version will be increased:I don't like option 1, but I have no preference if we use variant 2 or 3. Variant 2 is shorter, but variant 3 is using more modern CMake code.