Replace pcl_isnan, pcl_isfinite and pcl_isinf by C++11 methods

[SunBlack]

No description provided.

[SunBlack]

Compile issue is raised here:

pcl/common/include/pcl/common/point_tests.h

Lines 98 to 102 in 99a5b28

	template <> inline bool
	isFinite<pcl::BorderDescription> (const pcl::BorderDescription &p)
	{
	return (pcl_isfinite (p.x) && pcl_isfinite (p.y));
	}

Reason: p.x and p.y are of type int, but MS failed to implement bool isfinite( IntegralType arg ); correct.

I could simply change code to:

 template <> inline bool 
 isFinite<pcl::BorderDescription> (const pcl::BorderDescription &p) 
 { 
   return (std::isfinite (static_cast<double>(p.x)) && std::isfinite (static_cast<double>(p.y))); 
 } 

But this should always return true, because it is and int type and can't store and infinite value, or? So maybe this is better fix:

 template <> inline bool 
 isFinite<pcl::BorderDescription> (const pcl::BorderDescription &p) 
 { 
   return true; 
 } 

What do you think?

[taketwo]

Sure, integer can not be infinite; that test makes no sense. Just return true, perhaps move the specialization so that it's a part of the group of "always true" tests.

[SunBlack]

Found a lot of more senseless calls to these functions. Thanks for this compile issue MSVC to find this stupid calls 😄

Btw: I reordered template specialization lexicographically.

[taketwo]

The last commit has too many unrelated changes in my opinion. Could you please split it while addressing comments?

[SunBlack]

The last commit has too many unrelated changes in my opinion. Could you please split it while addressing comments?

They are not unrelated. This are all MSVC fixes (Azure failed before these changes).

[SergioRAgostinho]

As usual, thanks for the effort.