Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use I/O helper method in pcl::LineRGBD #2796

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Use I/O helper method in pcl::LineRGBD #2796

merged 1 commit into from
Jan 24, 2019

Conversation

SunBlack
Copy link
Contributor

Fixes #2788

@taketwo
Copy link
Member

taketwo commented Jan 21, 2019

I think we are missing pcl/io/low_level_io.h include.

@SunBlack
Copy link
Contributor Author

I think we are missing pcl/io/low_level_io.h include.

MSVC compiles without this include and clang is currently compiling, so we will see if it is really necessary ;). Could be because low_level_io.h is included in pcd_io.hpp and pcd_io will be included in nearly 350 other files, so maybe it is already included indirectly.

@SergioRAgostinho SergioRAgostinho merged commit 9acb2f9 into PointCloudLibrary:master Jan 24, 2019
@SunBlack SunBlack deleted the io_helper branch January 24, 2019 10:06
@taketwo taketwo changed the title Use I/O helper method in pcl::LineRGBD Use I/O helper method in pcl::LineRGBD Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho left review comments

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
module: recognition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MSVC: 'O_CLOEXEC': undeclared identifier
3 participants
@SunBlack @taketwo @SergioRAgostinho