Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize curvature in PointNormal default constructor #2674

Merged

Conversation

SergioRAgostinho
Copy link
Member

Fixes #2658

@SergioRAgostinho SergioRAgostinho changed the title Initialize curvature in PointNormal default ctor Initialize curvature in PointNormal default ctor Dec 2, 2018
@SergioRAgostinho SergioRAgostinho added the changelog: behavior change Meta-information for changelog generation label Dec 2, 2018
@taketwo
Copy link
Member

taketwo commented Dec 3, 2018

Well... the thing is that the data is sort of initialized. When cloud.resize() is invoked, it is calling the resize method of an STL vector.

You are right, good catch.

I'm not sure if we need to initialize padding floats in curvature (data_c). In coordinates and normals we do that because they can be used as homogeneous vectors (getVector4fMap()) and thus the last component should be 1/0 to ensure proper application of transforms. But we don't do anything like this with curvature data, so there is no reason to care about the contents of the padding bytes.

@SergioRAgostinho SergioRAgostinho added the needs: more work Specify why not closed/merged yet label Dec 3, 2018
@SergioRAgostinho SergioRAgostinho removed the needs: more work Specify why not closed/merged yet label Dec 3, 2018
@SergioRAgostinho
Copy link
Member Author

:shipit:

@taketwo taketwo merged commit 4d66dcb into PointCloudLibrary:master Dec 4, 2018
@SergioRAgostinho SergioRAgostinho deleted the autoloadcloudfiles branch December 5, 2018 21:24
@taketwo taketwo changed the title Initialize curvature in PointNormal default ctor Initialize curvature in PointNormal default constructor Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: behavior change Meta-information for changelog generation module: common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sporadical failures in test_io
2 participants