-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compound CMake targets for examples, tools, and apps #2673
Add compound CMake targets for examples, tools, and apps #2673
Conversation
Maybe add sth. like this for each new target:
|
👍 Sounds valuable. I'm not exactly using an IDE so it would be nice to get some visual input on how things get organized in the end. Are you using one @SunBlack? If positive, can you post a screenshot on how it looks on your IDE? I'm have to say I'm not really fond of this particular string Windows people @UnaNancyOwen @claudiofantacci, can any of you also post a screenshot of how the PCL project structure looks in VS? Edit: In the meantime I'm installing XCode. A part of me is dying... |
I don't have all dependencies on my home PC, so I can't create a screenshot of your branch. But it looks like this after this. I don't like
Similar for both other groups. |
Let me collect all variants here:
|
It doesn't matter. I prefer The only thing: Custom targets are written in uppercase in CMake by default ( |
I think I'll open a separate PR to beautify things and restrict this one to just adding the new targets. |
bcf2366
to
946aac4
Compare
946aac4
to
dbee05a
Compare
Edit: Needs a fix. For another day... |
dbee05a
to
e070813
Compare
Seems to be working again. Good for review. |
e070813
to
e25a59f
Compare
Thanks! Could you please add a brief summary in the PR description, so that clicking on the changelog item will give necessary information to those who are interested? |
With this PR three new compound targets were added to CMake, specifically: examples, tools and apps. The idea was to provide a target so that one could build all examples, tools and apps in a single invocation. So now if you want to build all examples you can simply call:
The same is valid for tools and apps. In case you're using an IDE, you should be able to see the newly added targets alongside other preexisting pcl targets.
Closes #2511