Remove conditional code for no longer supported versions of CMake #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taketwo
reviewed
Nov 30, 2018
|
@SunBlack Did you use a formatting tool? Which one? |
|
Notepad++ => Regex Search & Replace ;-) |
|
I think this is generated by a sequence of search/replace operations with regex :) |
|
This came to mind |
added 6 commits
November 30, 2018 15:41
* commands are now always in lowercase * remove unnecessary expressions in else/endif * unified whitespaces between command and bracket
…kage, find_path, include, mark_as_advanced, message, set, target_link_libraries
…yle of command if/else/elseif/endif
SunBlack
force-pushed
the
cmake_cleanup
branch
from
c59ad16
to
1cc592f
Compare
taketwo
approved these changes
Nov 30, 2018
|
Not sure what to do here. Our CI pipeline for windows broke today and I would like to ensure that things on Windows are also running ok, just for precaution. |
|
We can wait until CI is fixed and then rebase and retest this. |
|
@SunBlack I would like to suggest the usage of cmake_format for cmake cleanups. If you happen to use Sublime you can use the plugin I wrote to get functionalities like format on save while using cmake_format. |
added 2 commits
December 2, 2018 20:47
…o we don't need to check anymore if version is 2.8.X or below
|
Thanks @jasjuang. I will try this tool later. I think we have enough changes in this PR for now. |
taketwo
approved these changes
Dec 3, 2018
SergioRAgostinho
changed the title
taketwo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages ;-)