Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CMake policy 0048 #2608

Merged

Conversation

SergioRAgostinho
Copy link
Member

@SergioRAgostinho SergioRAgostinho commented Nov 9, 2018

To be merged only after #2605.

We start setting the project version in the project command and adopt the default naming variable conventions CMake uses. The following substitutions were applied

Old variables and their respective contents

PCL_VERSION = 1.9.0(-dev)
PCL_VERSION_PLAIN = 1.9.0(.99)

PCL_MAJOR_VERSION = 1
PCL_MINOR_VERSION = 9
PCL_REVISION_VERSION = 0

PCL_DEV_VERSION = (0/1)

The corresponding substitutions

PCL_VERSION_PLAIN ->    PCL_VERSION
PCL_VERSION ->  	    PCL_VERSION_PRETTY
PCL_MAJOR_VERSION ->    PCL_VERSION_MAJOR
PCL_MINOR_VERSION ->    PCL_VERSION_MINOR
PCL_REVISION_VERSION -> PCL_VERSION_PATCH

Closes #2577.

@SergioRAgostinho SergioRAgostinho changed the title Cmake policy 0048 Migrate CMake policy 0048 Nov 9, 2018
@SergioRAgostinho SergioRAgostinho added the needs: pr merge Specify why not closed/merged yet label Nov 9, 2018
cmake/pcl_utils.cmake Outdated Show resolved Hide resolved
@SergioRAgostinho SergioRAgostinho removed the needs: pr merge Specify why not closed/merged yet label Nov 10, 2018
@SergioRAgostinho
Copy link
Member Author

This is finished from my side.

@taketwo taketwo merged commit e200f00 into PointCloudLibrary:master Nov 12, 2018
@SergioRAgostinho SergioRAgostinho deleted the cmake-policy-0048 branch November 17, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants