Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove std::binary_function from Registration #2599

Merged
merged 2 commits into from
Nov 6, 2018
Merged

Remove std::binary_function from Registration #2599

merged 2 commits into from
Nov 6, 2018

Conversation

greenbrettmichael
Copy link
Contributor

Removed std::binary_function from Registration library to support C++17, this change should be reverse compatible

@taketwo
Copy link
Member

taketwo commented Nov 6, 2018

@SergioRAgostinho Should be safe to include in 1.9.0 I think.

@SergioRAgostinho
Copy link
Member

@taketwo safe to assume it breaks the ABI right?

@taketwo
Copy link
Member

taketwo commented Nov 6, 2018

I don't think so, it was a pure meta-programming gizmo. Here is how binary_function looks like in standard library (7.3.0):

template<typename _Arg1, typename _Arg2, typename _Result>
struct binary_function
{
/// @c first_argument_type is the type of the first argument
typedef _Arg1    first_argument_type;·
/// @c second_argument_type is the type of the second argument
typedef _Arg2    second_argument_type;
/// @c result_type is the return type
typedef _Result  result_type;
};

@SergioRAgostinho SergioRAgostinho merged commit 8d7040b into PointCloudLibrary:master Nov 6, 2018
@SergioRAgostinho
Copy link
Member

SergioRAgostinho commented Nov 6, 2018

Thank you both.

Edit: Forgot to squash 🤦‍♂️ sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants