Add setter/getter for search method in ConditionalEuclideanClustering #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToMadoRe
changed the title
| /** \brief Get a pointer to the search method used. | ||
| * @todo fix this for a generic search tree | ||
| */ | ||
| inline SearcherPtr |
There was a problem hiding this comment.
Pass a const reference out instead.
const SearcherPtr&| } | ||
|
|
||
| /** \brief Get a pointer to the search method used. | ||
| * @todo fix this for a generic search tree |
There was a problem hiding this comment.
Can you provide some more info on this comment?
There was a problem hiding this comment.
actually this was just copy/pasted from here:
https://github.com/PointCloudLibrary/pcl/blob/master/segmentation/include/pcl/segmentation/extract_clusters.h#L318
There was a problem hiding this comment.
Shall I just remove the @todo line? I don't see why the brief description would not be sufficient here.
There was a problem hiding this comment.
Yup let's go with that.
…euclidean clustering
SergioRAgostinho
approved these changes
Sep 12, 2018
taketwo
approved these changes
Sep 12, 2018
taketwo
changed the title
ToMadoRe
deleted the
add_missing_search_setter_for_conditional_clustering
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.