Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Visual Studio compiler option /FS for Ninja build #2414

Merged
merged 3 commits into from
Sep 6, 2018

Conversation

claudiofantacci
Copy link
Contributor

@claudiofantacci claudiofantacci commented Sep 6, 2018

This PR add the /FS compiler option to avoid multiple access to PDB files when

  • compiling PCL under Windows
  • with cl.exe compiler
  • using Ninja
  • with CUDA option enabled

Discussion about this can be found in #2412.
Main changes are in the first commit.

Coming through CMake files, I polished some code style in the main CMakeLists.txt and in pcl_find_cuda.cmake. Changes can be found in the other two commits.

Fixes #2412

@taketwo
Copy link
Member

taketwo commented Sep 6, 2018

Looks good to me. We'll most likely have conflicts with #2100. Who of you guys @SergioRAgostinho @claudiofantacci volunteers to have his PR merged second (and thus have to resolve conflicts)?

@SergioRAgostinho
Copy link
Member

Merge this one first. I'll handle #2100 .

@taketwo
Copy link
Member

taketwo commented Sep 6, 2018

Do we need any more testing here or ready to merge if AppVeyor succeeds?

@SergioRAgostinho
Copy link
Member

Merge once AppVeyor is done. It only affects ninja builds and adds a flag which supposedly is harmless.

@taketwo taketwo merged commit 22734a7 into PointCloudLibrary:master Sep 6, 2018
@claudiofantacci claudiofantacci deleted the devel/claudio branch September 7, 2018 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants