Remove malloc header to restore builds on BSDs #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In file included from common/src/fft/kiss_fft.c:16: In file included from common/include/pcl/common/fft/_kiss_fft_guts.h:19: In file included from common/include/pcl/common/fft/kiss_fft.h:10: /usr/include/malloc.h:3:2: error: "<malloc.h> has been replaced by <stdlib.h>" #error "<malloc.h> has been replaced by <stdlib.h>" ^ https://sourceforge.net/p/kissfft/code/ci/1a954c8a18b21b512c05b020d57f18d907ea412f/
|
The commit you referenced adds "stdlib.h" include instead. Is this not necessary? |
|
Which commit? |
|
I'm talking about the "downstream link" you provided, which adds the following patch: --- common/include/pcl/common/fft/kiss_fft.h.orig 2017-08-08 06:04:14 UTC
+++ common/include/pcl/common/fft/kiss_fft.h
@@ -7,7 +7,7 @@
#include <string.h>
#if !defined(__APPLE__)
-#include <malloc.h>
+#include <stdlib.h>
#endif
#include <pcl/pcl_exports.h>But you are right, in fact "stdlib.h" is already included, I overlooked that. |
Closed
SergioRAgostinho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<malloc.h>is unusable on FreeBSD, DragonFly, OpenBSD. On FreeBSD non-POSIX malloc extensions are in<malloc_np.h>. CC @yurivict per downstream hack.Let's backport the upstream fix.