Improve QHull finder script #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make sure QHULL_LIBRARIES and QHULL_INCLUDE_DIRS variables are not defined if QHull is not found * Make QHULL_LIBRARIES and QHULL_INCLUDE_DIRS advanced options * Some reformatting
|
Works! I tested by rebuilding our whole software stack (with many projects that depend on PCL) in a docker container without qhull installed. I explicitly printed out whether qhull was found in my projects, and verified that qhull was not found. You are awesome! |
SergioRAgostinho
approved these changes
Jun 18, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QHULL_LIBRARIESandQHULL_INCLUDE_DIRSvariables are not defined if QHull is not foundQHULL_LIBRARIESandQHULL_INCLUDE_DIRSadvanced optionsFixes #2343; similar to #2061.
@kgreenek please confirm that this works for you.