Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. typos (cont. 2) #2216

Closed
wants to merge 5 commits into from

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Feb 15, 2018

Found via codespell -q 3 -I ../pcl-whitelist.txt --skip="./surface/include/pcl/surface/3rdparty,./surface/src/3rdparty,./recognition/include/pcl/recognition/3rdparty"
Whitelist:

ang
childs
everytime
iff
indeces
isnt
ith
lod
metre
metres
mitre
nd
normaly
ot
resizeable
te
vertexes

Found via `codespell -q 3 -I ../pcl-whitelist.txt`

Whitelist:
```
ang
childs
indeces
ith
lod
metre
metres
nd
ot
te
vertexes
```
These I'm unsure about and need futher review.
Found via `codespell -q 3 -I ../pcl-whitelist.txt --skip="./surface/include/pcl/surface/3rdparty,./surface/src/3rdparty,./recognition/include/pcl/recognition/3rdparty"`  
Whitelist:
```
ang
childs
everytime
iff
indeces
isnt
ith
lod
metre
metres
mitre
nd
normaly
ot
resizeable
te
vertexes
```
@luzpaz
Copy link
Contributor Author

luzpaz commented Feb 15, 2018

Darn, I think i screwed this commit up. It shouldn't show that many files have been changed. I think it's because I branched this off of #2215 accidentally. I thought if I just rebased it off of master that it would reset it.

Is there a way I can eliminate the 3 previous commits and only keep: b3085a3 and
19c56e1 ?

@SergioRAgostinho
Copy link
Member

SergioRAgostinho commented Feb 15, 2018 via email

@luzpaz luzpaz closed this Feb 15, 2018
@luzpaz luzpaz deleted the misc-typos-cont-2 branch February 15, 2018 22:51
@luzpaz
Copy link
Contributor Author

luzpaz commented Feb 15, 2018

Closed in favor of #2217

@SergioRAgostinho
Copy link
Member

Is there a way I can eliminate the 3 previous commits and only keep: b3085a3 and
19c56e1 ?

Yes, using git's interactive rebasing functionality. You can drop out entire commits.

@luzpaz
Copy link
Contributor Author

luzpaz commented Feb 15, 2018

Yes, using git's interactive rebasing functionality. You can drop out entire commits.

Never used it before. Thanks for the heads-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants