Misc. typos (cont.) #2215
Merged
Misc. typos (cont.) #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found via `codespell -q 3 -I ../pcl-whitelist.txt` Whitelist: ``` ang childs indeces ith lod metre metres nd ot te vertexes ```
These I'm unsure about and need futher review.
|
Commits in 009cb02 need a little more extra review since source changes have been made. |
|
👍 There is one function change, but it is an util function in GPU module. I don't think we need to go through the deprecation procedure for that. |
SergioRAgostinho
approved these changes
Feb 15, 2018
gpu/features/src/spinimages.cu
Outdated
| @@ -244,7 +244,7 @@ namespace pcl | |||
| const float *amgles_end = amgles_beg + FSize; | |||
| const float *images_beg = simage_angles; | |||
|
|
|||
| Block::transfrom(amgles_beg, amgles_end, images_beg, output.ptr(i_input), Div12eps()); | |||
| Block::transform(amgles_beg, amgles_end, images_beg, output.ptr(i_input), Div12eps()); | |||
There was a problem hiding this comment.
I just noticed the amgles use all around. Could you also address this one?
|
pushed requested revision. (FYI, there are more typos but too many to include in this PR. Stay tuned for follow-ups) |
|
I didn't know we have a guideline on how many typos can be fixed in a single PR 😂 |
I didn't want to overwhelm. :) Actually it's less |
Closed
SergioRAgostinho
added
module: docs
changelog: API break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via
codespell -q 3 -I ../pcl-whitelist.txtWhitelist: