Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in example code for estimate set of surface for a subset of points in the input dataset #2203

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

vinjk
Copy link
Contributor

@vinjk vinjk commented Feb 6, 2018

I found an error in the example code in how_features_work.rst. The error was in the example code for estimate set of surface for a subset of points in the input dataset. The error was on Line 11 for loop.
Before correction,
before_pcl_how_features_work

After correction,
after_pcl_how_features_work

@SergioRAgostinho SergioRAgostinho added the needs: code review Specify why not closed/merged yet label Feb 6, 2018
Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, thanks.

@vinjk
Copy link
Contributor Author

vinjk commented Feb 6, 2018

Thanks for the approval. This is my first contribution!

@SergioRAgostinho
Copy link
Member

Keep them coming!

@SergioRAgostinho SergioRAgostinho merged commit ec03687 into PointCloudLibrary:master Feb 6, 2018
@SergioRAgostinho SergioRAgostinho added module: docs and removed needs: code review Specify why not closed/merged yet labels Feb 6, 2018
@SergioRAgostinho SergioRAgostinho changed the title fix error in Line 11 in example code for estimate set of surface for a subset of points in the input dataset Fix error in example code for estimate set of surface for a subset of points in the input dataset Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants