Small optimizations and fixes in PCLVisualizer#2112
Small optimizations and fixes in PCLVisualizer#2112taketwo merged 5 commits intoPointCloudLibrary:masterfrom
Conversation
Improve performance, fix compilation issues
|
Thanks. Could you also clarify these guards |
|
I added this guard, because in one of the recent VTK commits (somewhere in September/October) the function was removed (it was not defined in OpenGL2 at all, it had empty body) Update: it was not removed, but marked as deprecated |
visualization/src/pcl_visualizer.cpp
Outdated
| size_t i; | ||
| for (i = 0; i < point_cloud->points.size (); ++i) | ||
| poly_points->InsertPoint (i, point_cloud->points[i].x, point_cloud->points[i].y, point_cloud->points[i].z); | ||
| for (size_t i = 0; i < point_cloud->points.size (); ++i) { |
| void | ||
| removeOrientationMarkerWidgetAxes (); | ||
|
|
||
There was a problem hiding this comment.
Did we add some trailing spaces here?
|
|
||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Indentation here seemed correct. Having two } in consecutive lines with no indentation doesn't. What happened exactly?
visualization/src/pcl_visualizer.cpp
Outdated
| triangle->GetPoints ()->GetPoint (2, p2); | ||
| visible_area += vtkTriangle::TriangleArea (p0, p1, p2); | ||
| } | ||
| } |
There was a problem hiding this comment.
This also looks like a mistake. The indentation was similar to the opening bracket, before the change.
|
This is not exactly a refactoring, but more like a code style cleanup. I'll probably change the commit message to that if it's ok. |
taketwo
added
needs: code review
|
Changing the status back to "waiting feedback" because there's still two comments of my review left to be addressed. |
SergioRAgostinho
added
needs: author reply
handle VTK legacy function (follow up to #2112)
taketwo
changed the title
3 participants
Improve performance, fix compilation issues
Finally, I have found time to split my last pull request in several parts.