Remove deprecated ros headers #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioRAgostinho
added
the
changelog: API break
taketwo
approved these changes
Nov 11, 2017
|
@jspricke ping for the final check merge. |
|
I think this is fine, as we follow Semantic Versioning, only with a leading 1 ;). Normally I would propose to discuss things like this on the mailing list first (to give it a bigger audience), but I don't see it used lately... Thanks for cleaning up :). |
jspricke
approved these changes
Nov 12, 2017
This was referenced Aug 25, 2018
Closed
SergioRAgostinho
added
the
changelog: removal
SergioRAgostinho
removed
the
changelog: API break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last time these deprecated attributes were touched
38a6f8d
735b887