Skip to content

fix /MP option not generated for Visual Studio. - #2031

Merged
taketwo merged 1 commit into
PointCloudLibrary:masterfrom
kaikai2:master
Oct 18, 2017
Merged

fix /MP option not generated for Visual Studio.#2031
taketwo merged 1 commit into
PointCloudLibrary:masterfrom
kaikai2:master

Conversation

@kaikai2

@kaikai2 kaikai2 commented Oct 17, 2017

Copy link
Copy Markdown
Contributor

This is to fix #2030

@UnaNancyOwen

Copy link
Copy Markdown
Member

What is this commit 52d14ee?
If it is unnecessary, Please drop 52d14ee from this pull request.

@kaikai2

kaikai2 commented Oct 18, 2017

Copy link
Copy Markdown
Contributor Author

@UnaNancyOwen Sorry, I did not aware pull request keeps pulling the latest branch. I've reverted the commit 52d14ee.

52d14ee is a separate issue and has been included in another pull request #2032 already.

@taketwo taketwo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note for the future: it's better to create a separate topic branch for each pull request, this way your commits won't mix. Also, if you need to get rid of a commit in a pull request, you can do an interactive git rebase, delete the unneeded commit, and force push the branch.

Comment to maintainers: squash commits

@kaikai2

kaikai2 commented Oct 18, 2017

Copy link
Copy Markdown
Contributor Author

@taketwo Thanks for the note.

@kaikai2

kaikai2 commented Oct 18, 2017

Copy link
Copy Markdown
Contributor Author

@taketwo I did a force push just now for a try, and this pull request updates with the unwanted 2 commits removed swiftly. Since it is done after the approval, will this change cause a problem?

@taketwo

taketwo commented Oct 18, 2017

Copy link
Copy Markdown
Member

Great, thanks! No need to do squash on merge for us anymore :)

No, this is not a problem. This approval thing is just for our convenience to formalize comments like "LGTM" or "+1". It has no influence on "mergeability" of the pull request.

@UnaNancyOwen

Copy link
Copy Markdown
Member

LGTM

@taketwo
taketwo merged commit 41783c7 into PointCloudLibrary:master Oct 18, 2017
@kaikai2

kaikai2 commented Oct 18, 2017

Copy link
Copy Markdown
Contributor Author

OK. Cool! Thanks for clarifying that to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/MP not added to CMAKE_CXX_FLAGS for Visual Studio

4 participants