-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix /MP option not generated for Visual Studio. #2031
Conversation
@UnaNancyOwen Sorry, I did not aware pull request keeps pulling the latest branch. I've reverted the commit 52d14ee. 52d14ee is a separate issue and has been included in another pull request #2032 already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A note for the future: it's better to create a separate topic branch for each pull request, this way your commits won't mix. Also, if you need to get rid of a commit in a pull request, you can do an interactive git rebase, delete the unneeded commit, and force push the branch.
Comment to maintainers: squash commits
@taketwo Thanks for the note. |
@taketwo I did a force push just now for a try, and this pull request updates with the unwanted 2 commits removed swiftly. Since it is done after the approval, will this change cause a problem? |
Great, thanks! No need to do squash on merge for us anymore :) No, this is not a problem. This approval thing is just for our convenience to formalize comments like "LGTM" or "+1". It has no influence on "mergeability" of the pull request. |
LGTM |
OK. Cool! Thanks for clarifying that to me. |
This is to fix #2030