Fixed queryBBIncludes_subsample #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taketwo
reviewed
Sep 5, 2017
| @@ -1639,7 +1639,8 @@ namespace pcl | |||
| random_sampler.setSample (static_cast<unsigned int> (sample_points)); | |||
|
|
|||
| pcl::ExtractIndices<pcl::PCLPointCloud2> extractor; | |||
|
|
|||
| extractor.setInputCloud(tmp_blob); | |||
There was a problem hiding this comment.
Please replace tabs with spaces. Also add a space between function name and brackets to match PCL style. Thanks!
There was a problem hiding this comment.
Please check. I hope everything is ok now. Thanks.
raulmola
force-pushed
the
fix-in-outofcore-impl-octree-base-node
branch
from
837f537
to
ee66ae6
Compare
Extractor's input cloud was not set and sample_points cast to int could reach zero (e.g. if sample_points=0.9)
raulmola
force-pushed
the
fix-in-outofcore-impl-octree-base-node
branch
from
ee66ae6
to
30eee6d
Compare
taketwo
approved these changes
Sep 5, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extractor's input cloud was not set and sample_points cast to int could
reach zero (e.g. if sample_points=0.9)